Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## master #96 +/- ##
=======================================
Coverage 90.52% 90.52%
=======================================
Files 33 33
Lines 2249 2249
=======================================
Hits 2036 2036
Misses 213 213Continue to review full report at Codecov.
|
Contributor
Author
|
Gentle ping on this |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
cc @dwsupplee @jdpedrie Once googleapis/google-cloud-php#600 is merged we should create a similar PR for google-cloud-php
Note that this doesn't test all combinations of platforms and c extension presence/absence - this is only to be a good citizen for Travis, as the extra testing combinations are (IMHO) unlikely to find issues.